Syntax error in scripting HTML using javascript

The name of the pictureThe name of the pictureThe name of the pictureClash Royale CLAN TAG#URR8PPP



Syntax error in scripting HTML using javascript



I have the following javascript code that attempts to insert HTML code dynamically. I have an error the syntax but I do not know how to correct it. Please can someone advise?


loadNextContainer.innerHTML = '<span class="sr_43" id="srloadnext_2" onclick="srt.loadNextMatchRecords(''+numDownloadSoFar+'', ''+maxDownloadLimit+'', ''+folderName+'', ''+jsonHashTags+'', ''+fromDate+'', ''+toDate+'', ''+lastScanId+'')">LoadNext</span>';



ERROR MESSAGE:


Uncaught SyntaxError: Invalid or unexpected token



I believe the error revovles around the function variables. In particular the JSON variable. I cannot change the use of double quotation marks for each element in the JSON. So that has to stay in any solution.



enter image description here





well you can always use template literal expression in such cases to avoid syntax issues
– George Bailey
Aug 11 at 23:07





When you are concatenating your strings + variables, you are using single quotes that are opening the string unexpectedly. For example, look at just this piece: jsonHashTags+'', ''+fromDate. You have single quotes inside your single quotes.
– xHocquet
Aug 11 at 23:10


jsonHashTags+'', ''+fromDate





@xHocquet Appreciate the reply. But it would really help if you could re-write the line of code in above with the correct syntax. I would be able to better understand.
– jamesMcKey
Aug 11 at 23:13




3 Answers
3



Judging from your image of your variables, none of the template literal solutions are going to help you, because at least one of your parameters is an array.


template literal



Yes, it would be possible, with enough effort, to convert that array into a string representation that would work with innerHTML. But it's going to be very difficult. You'd end up needing to use JSON.stringify to get the string version of your array at least.


innerHTML


JSON.stringify



An easier solution is actually going to be to create the element and then add the onclick operator through pure javascript, like this:


var s = document.createElement('span');
s.className = 'sr_43';
s.id = 'srloadnext_2';
s.innerText = 'LoadNext';
loadNextContainer.appendChild(s);
s.onclick = function(e)
srt.loadNextMatchRecords(numDownloadSoFar, maxDownloadLimit, folderName, jsonHashTags, fromDate, toDate, lastScanId);
;





I used your code above but it failed to incorporate the onclick attribute in the span element? I even tried placing the s.onclick line before adding loadNextContainer.appendChild(s);.
– jamesMcKey
Aug 12 at 0:04





I can't imagine why it wouldn't be attaching the listener; perhaps it's a javascript error rather than a failure to attach? Have you checked the browser console for errors?
– David784
Aug 12 at 0:14





-ignore above. you are correct. sorry
– jamesMcKey
Aug 12 at 0:22



You could try it using backticks like this.


loadNextContainer.innerHTML = `<span class="sr_43" id="srloadnext_2" onclick="srt.loadNextMatchRecords('`+numDownloadSoFar+`', '`+maxDownloadLimit+`', '`+folderName+`', '`+jsonHashTags+`', '`+fromDate+`', '`+toDate+`', '`+lastScanId+`')">LoadNext</span>';



Or just escape the double-quotes instead of the single quotes. The way you're doing it, you're unintentionally opening up the string when you try to escape it.


loadNextContainer.innerHTML = "<span class="sr_43" id="srloadnext_2" onclick="srt.loadNextMatchRecords('"+numDownloadSoFar+"', '"+maxDownloadLimit+"', '"+folderName+"', '"+jsonHashTags+"', '"+fromDate+"', '"+toDate+"', '"+lastScanId+"')">LoadNext</span>";





If you look at the image in his question, one of his parameters is an array. Template literal won't help with that, not without him doing a JSON.stringify or something.
– David784
Aug 11 at 23:41


JSON.stringify





@David784 is correct.
– jamesMcKey
Aug 11 at 23:46



Try it with template literals:


loadNextContainer.innerHTML = `<span class="sr_43" id="srloadnext_2" onclick="srt.loadNextMatchRecords('$numDownloadSoFar', '$maxDownloadLimit', '$folderName', '$jsonHashTags', '$fromDate', '$toDate', '$lastScanId')">LoadNext</span>`;



Edit:
As others already mentioned. Sorry.






By clicking "Post Your Answer", you acknowledge that you have read our updated terms of service, privacy policy and cookie policy, and that your continued use of the website is subject to these policies.

-

Popular posts from this blog

Firebase Auth - with Email and Password - Check user already registered

Image
Clash Royale CLAN TAG #URR8PPP Firebase Auth - with Email and Password - Check user already registered I want to check when a user attempts to signup with createUserWithEmailAndPassword() in Firebase user Authentication method, this user is already registered with my app. createUserWithEmailAndPassword() 8 Answers 8 To detect whether a user with that email address already exists, you can detect when the call to createUserWithEmailAndPassword () fails with auth/email-already-in-use . I see that @Srinivasan just posted an answer for this. createUserWithEmailAndPassword () auth/email-already-in-use Alternatively, you can detect that an email address is already used by calling fetchSignInMethodsForEmail() (previous called fetchProvidersForEmail() ). fetchSignInMethodsForEmail() fetchProvidersForEmail() When the user trying to create an user with same email address, the task response will be "Response: The email address is already in use by another account." mFirebas...
Read more

Dynamically update html content plain JS

Image
Clash Royale CLAN TAG #URR8PPP Dynamically update html content plain JS So I have a script bound in my index.html, which literally has to fetch an array of jsons from an api, then dynamically update my page when get response. But as a result I'm getting an as the only update of my page. here is my script fetch(url) .then((resp) => resp.json()) .then((resp) => resp.results.forEach(item => fetch(item.url) .then((response)=> response.json()) .then((response) => pokeArr.push(response)) .catch(console.log) ) ).catch(console.log) const filler = () => if(!pokeArr) return 0 pokeArr.map((i,j)=> return `<tr>$i.name</tr>` ) const pokeindex = () => document.getElementById('a').appendChild(document.createElement(filler())) pokeindex() When I'm consoling it, I can see in the console all the responses I get, so I'm at least doing the fetching part right. What's parberakan ? What's pokeArr ? – T.J. Crowder Aug 8 at 12...
Read more

Creating a leaderboard in HTML/JS

Image
Clash Royale CLAN TAG #URR8PPP Creating a leaderboard in HTML/JS I'm trying to create a top 10 leaderboard, for now, I've only implemented 3 players, but I'm coming across an issue. My script doesn't seem to be outputting anything on webpage. The purpose of the script is to compare 3 arrays, player1,player2,and player3 solely based off of score. Which is the 2nd index of each array. I want the script to list the players in order of highest score. This method doesn't really seem to be efficient, especially when I'll have to add 7 more players. Could someone suggest perhaps an easier approach, as well as show me why my script wont output the info. Here's the JS function leaderboard() { var player1 = name:"Thomas",date:"01/23/18",score:"201"; var player2 = name:"Michael",date:"03/24/17",score:"943"; var player3 = Name:"Lisa",date:"06/04/18",Score:"79"; if(player1[2]...
Read more