How to fix this collision detection? [duplicate]

The name of the pictureThe name of the pictureThe name of the pictureClash Royale CLAN TAG#URR8PPP



How to fix this collision detection? [duplicate]



This question already has an answer here:



I'm trying to create a simple Space Invaders game in JavaFX. This is my first time so I have no idea how you properly do this. I'm trying to add collision detection, to remove a sprite if it's hit by a bullet.



All my sprites are rectangles with an imagePattern.



The enemies are 60 x 43, the bullet is 4 x 8. My idea was to just check if the bullet is within the translateX of a sprite, and if its the same Translate Y - its height. But for some reason this code doesn't work. It causes an Exception in thread "JavaFX Application Thread" java.lang.NullPointerException when a bullet hits a sprite.


Exception in thread "JavaFX Application Thread" java.lang.NullPointerException


if (game.lookup("#bullet") != null)
for (Sprite sprite : enemies)
if (game.lookup("#bullet").getTranslateX() >= sprite.getTranslateX() && game.lookup("#bullet").getTranslateX() <= sprite.getTranslateX() + 60 && game.lookup("#bullet").getTranslateY() == sprite.getTranslateY() - 43)
System.out.println("HIT!");





Some help would be much appreciated.



Note: I am sure this is not the most efficient way to go about it, but its the only idea I have.



The stack trace:


Exception in thread "JavaFX Application Thread" java.lang.NullPointerException
at Main$1.handle(Main.java:131)
at javafx.graphics/javafx.animation.AnimationTimer$AnimationTimerReceiver.lambda$handle$0(AnimationTimer.java:57)
at java.base/java.security.AccessController.doPrivileged(Native Method)
at javafx.graphics/javafx.animation.AnimationTimer$AnimationTimerReceiver.handle(AnimationTimer.java:56)
at javafx.graphics/com.sun.scenario.animation.AbstractMasterTimer.timePulseImpl(AbstractMasterTimer.java:357)
at javafx.graphics/com.sun.scenario.animation.AbstractMasterTimer$MainLoop.run(AbstractMasterTimer.java:267)
at javafx.graphics/com.sun.javafx.tk.quantum.QuantumToolkit.pulse(QuantumToolkit.java:514)
at javafx.graphics/com.sun.javafx.tk.quantum.QuantumToolkit.pulse(QuantumToolkit.java:498)
at javafx.graphics/com.sun.javafx.tk.quantum.QuantumToolkit.pulseFromQueue(QuantumToolkit.java:491)
at javafx.graphics/com.sun.javafx.tk.quantum.QuantumToolkit.lambda$runToolkit$11(QuantumToolkit.java:319)
at javafx.graphics/com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:96)
at javafx.graphics/com.sun.glass.ui.win.WinApplication._runLoop(Native Method)
at javafx.graphics/com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(WinApplication.java:175)
at java.base/java.lang.Thread.run(Thread.java:844)



This question has been asked before and already has an answer. If those answers do not fully address your question, please ask a new question.





Please post the exception stack trace
– Karol Dowbecki
Aug 10 at 9:33





Not sure if thats readable.. I can post my entire code if you need it too.
– Behar
Aug 10 at 9:37






That is the if statement, however anon fixed that error. It turns out i had simple forgotten a # symbol in the game.lookup(bullet) statement. However after fixing that, now the detection dosent work at all, the "HIT!" message is never printed, even tho the bullet passes thru all the sprites. And its weird because before the excpetions only began when the bullet actually hit a sprite.
– Behar
Aug 10 at 9:43





1 Answer
1



One of your "bullet" keys seems to be missing its '#'.





Waw, so i fixed that, and now the error is gone. But it still does not print the "HIT!" message when a sprite it hit. Which is weird because the error only began when a sprite was hit before, so it kinda seemed to work.
– Behar
Aug 10 at 9:39





You have an upper and a lower bound for X, but only a single Y value - are you sure that bullets can't pass beyond the sprite boundary (e.g. depending on speed)?
– anon
Aug 10 at 9:47





Fundamentally speaking, I strongly advise you to introduce enums or named constants and local variables with clear names. Fetching your bullet once with a constant key would have prevented the exception in the first place. Same applies for your height / width constants. Cumbersome typing avoids even more cumbersome errors.
– anon
Aug 10 at 9:51





Hey anon, yea as i mentioned im sure there are much better ways to do this. But im a beginner in programming, ill be sure to check out the stuff you mentioned tho. That being said the error was exacly what you said, i increased the translate Y in my bullet by 8 every frame, so i obviously should not have used the == operator but instead the > operator. Thank you so much for your help anyway!
– Behar
Aug 10 at 9:56

-

Popular posts from this blog

Firebase Auth - with Email and Password - Check user already registered

Image
Clash Royale CLAN TAG #URR8PPP Firebase Auth - with Email and Password - Check user already registered I want to check when a user attempts to signup with createUserWithEmailAndPassword() in Firebase user Authentication method, this user is already registered with my app. createUserWithEmailAndPassword() 8 Answers 8 To detect whether a user with that email address already exists, you can detect when the call to createUserWithEmailAndPassword () fails with auth/email-already-in-use . I see that @Srinivasan just posted an answer for this. createUserWithEmailAndPassword () auth/email-already-in-use Alternatively, you can detect that an email address is already used by calling fetchSignInMethodsForEmail() (previous called fetchProvidersForEmail() ). fetchSignInMethodsForEmail() fetchProvidersForEmail() When the user trying to create an user with same email address, the task response will be "Response: The email address is already in use by another account." mFirebas
Read more

Dynamically update html content plain JS

Image
Clash Royale CLAN TAG #URR8PPP Dynamically update html content plain JS So I have a script bound in my index.html, which literally has to fetch an array of jsons from an api, then dynamically update my page when get response. But as a result I'm getting an as the only update of my page. here is my script fetch(url) .then((resp) => resp.json()) .then((resp) => resp.results.forEach(item => fetch(item.url) .then((response)=> response.json()) .then((response) => pokeArr.push(response)) .catch(console.log) ) ).catch(console.log) const filler = () => if(!pokeArr) return 0 pokeArr.map((i,j)=> return `<tr>$i.name</tr>` ) const pokeindex = () => document.getElementById('a').appendChild(document.createElement(filler())) pokeindex() When I'm consoling it, I can see in the console all the responses I get, so I'm at least doing the fetching part right. What's parberakan ? What's pokeArr ? – T.J. Crowder Aug 8 at 12
Read more

How to determine optimal route across keyboard

Image
Clash Royale CLAN TAG #URR8PPP How to determine optimal route across keyboard I'm trying to automate the typing process in a video game. Players are given an on-screen QWERTY keyboard layout that they can navigate with the control stick (up, down, left, right) in order to select a letter to type. I was wondering if there was a module for Python (or some other resource I could explore) that would help my program find a path across the keyboard as it types each letter in a given message. In other words, if the first letter typed was "A" and the next letter was "B", the module would know that the program should move 1 space down on the keyboard and 4 spaces to the right. Currently, I have the program resetting to the "G" key after each letter is typed (allowing me to use fixed-directions as the program parses each character in the desired message). As you can imagine, this is quite inefficient and defeats the purpose of automating the typing in the fir
Read more