Git add in pre-commit hook not staging file for commit

The name of the pictureThe name of the pictureThe name of the pictureClash Royale CLAN TAG#URR8PPP



Git add in pre-commit hook not staging file for commit



I have written a pre-commit hook that compiles my project and adds the generated file to the commit.



This is a JavaScript project and I am using husky, but I have experimented with editing the .git/hooks/pre-commit as well and the file is not getting added to the commit. If I cancel the commit, I can see the file has been added, but for some reason this is not applying to the current commit.



My pre-commit hook looks something like:


const shell = require('shelljs');

shell.exec('yarn bundle');
shell.exec('git add dist');
shell.exit(0);



shelljs is just a library to execute cross-OS unix commands in node


shelljs



I edited the .git/hooks/pre-commit to run git add dist and the file is still not added to the commit


.git/hooks/pre-commit


git add dist





Is the hook actually executed? It needs the executable bit set, and might be ignored if it is not there. Also check without the shelljs, calling git add dist directly
– Dmitriy Smirnov
Aug 10 at 7:30


git add dist





Possible duplicate of Can a Git hook automatically add files to the commit?
– Dmitriy Smirnov
Aug 10 at 7:32





The hook is definitely executed yeah, and I did try just running git add dist but it still didn't work
– Heather Roberts
Aug 12 at 23:26


git add dist




1 Answer
1



I don't think a git add can work in a pre-commit hook, made to inspect what is about to be committed, not to modify it.


git add



You can follow an approach similar to "Can a Git hook automatically add files to the commit?" instead, which creates a separate additional commit.





Adding files via pre-commit hooks actually works. consider the simplest hook echo text > test.file && git add test.file - worked for me.
– Dmitriy Smirnov
Aug 10 at 7:28


echo text > test.file && git add test.file





@DmitriySmirnov OK, still seems "wrong" to me ;)
– VonC
Aug 10 at 7:30





What about pre-push? You can commit always, but when trying to push, you can actually generate other files, add them, commit them programmatically, and issue a exit(0) so the push will happen. But yes, "seems wrong" as @VonC said.
– Lovato
Aug 10 at 13:20






Thanks @VonC using that other question's solution did help me, but I would have liked to be able to add an extra file in the pre-commit hook...
– Heather Roberts
Aug 12 at 23:31






By clicking "Post Your Answer", you acknowledge that you have read our updated terms of service, privacy policy and cookie policy, and that your continued use of the website is subject to these policies.

-

Popular posts from this blog

Firebase Auth - with Email and Password - Check user already registered

Image
Clash Royale CLAN TAG #URR8PPP Firebase Auth - with Email and Password - Check user already registered I want to check when a user attempts to signup with createUserWithEmailAndPassword() in Firebase user Authentication method, this user is already registered with my app. createUserWithEmailAndPassword() 8 Answers 8 To detect whether a user with that email address already exists, you can detect when the call to createUserWithEmailAndPassword () fails with auth/email-already-in-use . I see that @Srinivasan just posted an answer for this. createUserWithEmailAndPassword () auth/email-already-in-use Alternatively, you can detect that an email address is already used by calling fetchSignInMethodsForEmail() (previous called fetchProvidersForEmail() ). fetchSignInMethodsForEmail() fetchProvidersForEmail() When the user trying to create an user with same email address, the task response will be "Response: The email address is already in use by another account." mFirebas
Read more

Dynamically update html content plain JS

Image
Clash Royale CLAN TAG #URR8PPP Dynamically update html content plain JS So I have a script bound in my index.html, which literally has to fetch an array of jsons from an api, then dynamically update my page when get response. But as a result I'm getting an as the only update of my page. here is my script fetch(url) .then((resp) => resp.json()) .then((resp) => resp.results.forEach(item => fetch(item.url) .then((response)=> response.json()) .then((response) => pokeArr.push(response)) .catch(console.log) ) ).catch(console.log) const filler = () => if(!pokeArr) return 0 pokeArr.map((i,j)=> return `<tr>$i.name</tr>` ) const pokeindex = () => document.getElementById('a').appendChild(document.createElement(filler())) pokeindex() When I'm consoling it, I can see in the console all the responses I get, so I'm at least doing the fetching part right. What's parberakan ? What's pokeArr ? – T.J. Crowder Aug 8 at 12
Read more

How to determine optimal route across keyboard

Image
Clash Royale CLAN TAG #URR8PPP How to determine optimal route across keyboard I'm trying to automate the typing process in a video game. Players are given an on-screen QWERTY keyboard layout that they can navigate with the control stick (up, down, left, right) in order to select a letter to type. I was wondering if there was a module for Python (or some other resource I could explore) that would help my program find a path across the keyboard as it types each letter in a given message. In other words, if the first letter typed was "A" and the next letter was "B", the module would know that the program should move 1 space down on the keyboard and 4 spaces to the right. Currently, I have the program resetting to the "G" key after each letter is typed (allowing me to use fixed-directions as the program parses each character in the desired message). As you can imagine, this is quite inefficient and defeats the purpose of automating the typing in the fir
Read more