IllegalStateException: Can not perform this action after onSaveInstanceState with ViewPager

The name of the pictureThe name of the pictureThe name of the pictureClash Royale CLAN TAG#URR8PPP



IllegalStateException: Can not perform this action after onSaveInstanceState with ViewPager



I'm getting user reports from my app in the market, delivering the following exception:


java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState
at android.app.FragmentManagerImpl.checkStateLoss(FragmentManager.java:1109)
at android.app.FragmentManagerImpl.popBackStackImmediate(FragmentManager.java:399)
at android.app.Activity.onBackPressed(Activity.java:2066)
at android.app.Activity.onKeyUp(Activity.java:2044)
at android.view.KeyEvent.dispatch(KeyEvent.java:2529)
at android.app.Activity.dispatchKeyEvent(Activity.java:2274)
at com.android.internal.policy.impl.PhoneWindow$DecorView.dispatchKeyEvent(PhoneWindow.java:1803)
at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1112)
at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1112)
at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1112)
at com.android.internal.policy.impl.PhoneWindow$DecorView.superDispatchKeyEvent(PhoneWindow.java:1855)
at com.android.internal.policy.impl.PhoneWindow.superDispatchKeyEvent(PhoneWindow.java:1277)
at android.app.Activity.dispatchKeyEvent(Activity.java:2269)
at com.android.internal.policy.impl.PhoneWindow$DecorView.dispatchKeyEvent(PhoneWindow.java:1803)
at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1112)
at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1112)
at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1112)
at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1112)
at android.widget.TabHost.dispatchKeyEvent(TabHost.java:297)
at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1112)
at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1112)
at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1112)
at com.android.internal.policy.impl.PhoneWindow$DecorView.superDispatchKeyEvent(PhoneWindow.java:1855)
at com.android.internal.policy.impl.PhoneWindow.superDispatchKeyEvent(PhoneWindow.java:1277)
at android.app.Activity.dispatchKeyEvent(Activity.java:2269)
at com.android.internal.policy.impl.PhoneWindow$DecorView.dispatchKeyEvent(PhoneWindow.java:1803)
at android.view.ViewRoot.deliverKeyEventPostIme(ViewRoot.java:2880)
at android.view.ViewRoot.handleFinishedEvent(ViewRoot.java:2853)
at android.view.ViewRoot.handleMessage(ViewRoot.java:2028)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:132)
at android.app.ActivityThread.main(ActivityThread.java:4028)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:491)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:844)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:602)
at dalvik.system.NativeStart.main(Native Method)



Apparently it has something to do with a FragmentManager, which I don't use. The stacktrace doesn't show any of my own classes, so I have no idea where this exception occurs and how to prevent it.



For the record: I have a tabhost, and in each tab there is a ActivityGroup switching between Activities.





I found this question discussing the same issue, but no solution there either.. stackoverflow.com/questions/7469082/…
– nhaarman
Sep 27 '11 at 21:32





While you are not using FragmentManager, Honeycomb certainly is. Is this happening on real Honeycomb tablets? Or might it be that somebody is running a hacked Honeycomb on a phone or something and it's that hacked edition that is having difficulty?
– CommonsWare
Sep 27 '11 at 21:35


FragmentManager





I have no idea. This is the only information I get in the Market Developer Console, the user message contains no useful info either..
– nhaarman
Sep 27 '11 at 21:40





I am using Flurry, which shows me 11 sessions with Android 3.0.1, and I have 11 reports of this exception. Could be coincidence though. Android 3.1 and 3.2 have 56 and 38 sessions, respectively.
– nhaarman
Sep 27 '11 at 21:43





The Market error report has a 'Platform' section, sometimes it has the Android version of the device in it.
– Nikolay Elenkov
Sep 28 '11 at 4:18




26 Answers
26



Please check my answer here. Basically I just had to :


@Override
protected void onSaveInstanceState(Bundle outState)
//No call for super(). Bug on API Level > 11.



Don't make the call to super() on the saveInstanceState method. This was messing things up...


super()


saveInstanceState



This is a known bug in the support package.



If you need to save the instance and add something to your outState Bundle you can use the following:


outState


Bundle


@Override
protected void onSaveInstanceState(Bundle outState)
outState.putString("WORKAROUND_FOR_BUG_19917_KEY", "WORKAROUND_FOR_BUG_19917_VALUE");
super.onSaveInstanceState(outState);



In the end the proper solution was (as seen in the comments) to use :


transaction.commitAllowingStateLoss();



when adding or performing the FragmentTransaction that was causing the Exception.


FragmentTransaction


Exception





You should use commitAllowingStateLoss() instead of commit()
– meh
Sep 28 '12 at 9:44





This comment about commitAllowingStateLoss() is an answer in its own right - you should post it as that.
– Risadinha
Oct 15 '13 at 17:59





Regarding 'commitAllowingStateLoss' --/> "This is dangerous because the commit can be lost if the activity needs to later be restored from its state, so this should only be used for cases where it is okay for the UI state to change unexpectedly on the user."
– Codeversed
Dec 17 '13 at 2:44





If I look at the v4 source for popBackStackImmediate it immediately fails if the state has been saved. Previously adding the fragment with commitAllowingStateLoss doesn't play any part. My testing shows this to be true. It has no effect on this specific exception. What we need is a popBackStackImmediateAllowingStateLoss method.
– Synesso
Jan 9 '15 at 1:32



popBackStackImmediate


commitAllowingStateLoss


popBackStackImmediateAllowingStateLoss





@DanieleB yes, I've posted an answer here. But I've actually found an even better solution by using Otto message bus: register the fragment as a subscriber and listen for the async result from the bus. Unregister on pause and re-register on resume. The async also needs a Produce method for the times when it completes and the fragment is paused. When I get time I'll update my answer with this in more detail.
– Synesso
Mar 8 '15 at 21:25



There are many related problems with a similar error message. Check the second line of this particular stack trace. This exception is specifically related to the call to FragmentManagerImpl.popBackStackImmediate.


FragmentManagerImpl.popBackStackImmediate



This method call, like popBackStack, will always fail with IllegalArgumentException if the session state has already been saved. Check the source. There is nothing you can do to stop this exception being thrown.


popBackStack


IllegalArgumentException


super.onSaveInstanceState


commitAllowingStateLoss



Here's how I observed the problem:


onSaveInstanceState


popBackStackImmediate


IllegalStateException



Here's what I did to solve it:



As it is not possible to avoid the IllegalStateException in the callback, catch & ignore it.


IllegalStateException


try
activity.getSupportFragmentManager().popBackStackImmediate(name);
catch (IllegalStateException ignored)
// There's no way to avoid getting this if saveInstanceState has already been called.



This is enough to stop the app from crashing. But now the user will restore the app and see that the button they thought they'd pressed hasn't been pressed at all (they think). The form fragment is still showing!



To fix this, when the dialog is created, make some state to indicate the process has started.


progressDialog.show(fragmentManager, TAG);
submitPressed = true;



And save this state in the bundle.


@Override
public void onSaveInstanceState(Bundle outState)
...
outState.putBoolean(SUBMIT_PRESSED, submitPressed);



Don't forget to load it back again in onViewCreated


onViewCreated



Then, when resuming, rollback the fragments if submit was previously attempted. This prevents the user from coming back to what seems like an un-submitted form.


@Override
public void onResume()
super.onResume();
if (submitPressed)
// no need to try-catch this, because we are not in a callback
activity.getSupportFragmentManager().popBackStackImmediate(name);
submitPressed = false;






This must be the accepted answer, commitAllowingStateLoss just do things worse.
– zzy
Jun 5 '15 at 2:55





Interesting reading about that here: androiddesignpatterns.com/2013/08/…
– Pascal
Apr 18 '16 at 6:48





If you use DialogFragment, I've made an alternative to it here: github.com/AndroidDeveloperLB/DialogShard
– android developer
Oct 22 '16 at 15:05





What if the popBackStackImmediate was called by Android itself?
– Kimi Chiu
Nov 25 '16 at 2:59


popBackStackImmediate





Absolutely great. This one should be the accepted answer. Thank you very much! Maybe I would add submitPressed = false; after popBackStackInmediate.
– Neonigma
May 15 at 8:55




Check if the activity isFinishing() before showing the fragment and pay attention to commitAllowingStateLoss().


isFinishing()


commitAllowingStateLoss()



Example:


if(!isFinishing())
FragmentManager fm = getSupportFragmentManager();
FragmentTransaction ft = fm.beginTransaction();
DummyFragment dummyFragment = DummyFragment.newInstance();
ft.add(R.id.dummy_fragment_layout, dummyFragment);
ft.commitAllowingStateLoss();





ft.commitAllowingStateLoss() solved the issue. Thanks and +1
– Sami Eltamawy
May 12 '15 at 13:21


ft.commitAllowingStateLoss()





isFinishing() does the tricks thank you
– Netero
Dec 1 '15 at 13:10





This did not resolve the issue for me.
– frank
Mar 15 '17 at 19:30





!isFinishing() && !isDestroyed() doesn't work for me.
– Allen Vork
Feb 6 at 6:35



Here is a different solution to this problem.



Using a private member variable you are able to set the returned data as an intent that can then be processed after super.onResume();



Like so:


private Intent mOnActivityResultIntent = null;

@Override
protected void onResume()
super.onResume();
if(mOnActivityResultIntent != null)
... do things ...
mOnActivityResultIntent = null;



@Override
public void onActivityResult(int requestCode, int resultCode, Intent data)
if(data != null)
mOnActivityResultIntent = data;






Depending on what action you were doing that wasn't allowed, this might need to move to an even later moment than onResume(). For insatcne, if FragmentTransaction.commit() is the problem, this needs to go into onPostResume() instead.
– pjv
Nov 25 '12 at 17:22





This is THE answer to this question for me. Since I needed to forward a received NFC tag to the previous activity, this is what did it for me.
– Janis Peisenieks
Jul 16 '13 at 7:14





For me it was happening because I was not calling super.onActivityResult().
– Sufian
Feb 10 '15 at 11:40


super.onActivityResult()



It's October 2017, and Google makes Android Support Library with the new things call Lifecycle component. It provides some new idea for this 'Can not perform this action after onSaveInstanceState' problem.



In short:



Longer version with explain:



why this problem come out?



It's because you are trying to use FragmentManager from your activity(which is going to hold your fragment I suppose?) to commit a transaction for you fragment. Usually this would look like you are trying to do some transaction for an up coming fragment, meanwhile the host activity already call savedInstanceState method(user may happen to touch the home button so the activity calls onStop(), in my case it's the reason)


FragmentManager


savedInstanceState


onStop()



Usually this problem shouldn't happen -- we always try to load fragment into activity at the very beginning, like the onCreate() method is a perfect place for this. But sometimes this do happen, especially when you can't decide what fragment you will load to that activity, or you are trying to load fragment from an AsyncTask block(or anything will take a little time). The time, before the fragment transaction really happens, but after the activity's onCreate() method, user can do anything. If user press the home button, which triggers the activity's onSavedInstanceState() method, there would be a can not perform this action crash.


onCreate()


AsyncTask


onCreate()


onSavedInstanceState()


can not perform this action



If anyone want to see deeper in this issue, I suggest them to take a look at this blog post. It looks deep inside the source code layer and explain a lot about it. Also, it gives the reason that you shouldn't use the commitAllowingStateLoss() method to workaround this crash(trust me it offers nothing good for your code)


commitAllowingStateLoss()



How to fix this?



Should I use commitAllowingStateLoss() method to load fragment? Nope you shouldn't;


commitAllowingStateLoss()



Should I override onSaveInstanceState method, ignore super method inside it? Nope you shouldn't;


onSaveInstanceState


super



Should I use the magical isFinishing inside activity, to check if the host activity is at the right moment for fragment transaction? Yeah this looks like the right way to do.


isFinishing



Take a look at what Lifecycle component can do.



Basically, Google makes some implementation inside the AppCompatActivity class(and several other base class you should use in your project), which makes it a easier to determine current lifecycle state. Take a look back to our problem: why would this problem happen? It's because we do something at the wrong timing. So we try not to do it, and this problem will be gone.


AppCompatActivity



I code a little for my own project, here is what I do using LifeCycle. I code in Kotlin.


LifeCycle


val hostActivity: AppCompatActivity? = null // the activity to host fragments. It's value should be properly initialized.

fun dispatchFragment(frag: Fragment)
hostActivity?.let
if(it.lifecyclecurrentState.isAtLeast(Lifecycle.State.RESUMED))
showFragment(frag)




private fun showFragment(frag: Fragment) {
hostActivity?.let
Transaction.begin(it, R.id.frag_container)
.show(frag)
.commit()



As I show above. I will check the lifecycle state of the host activity. With Lifecycle component within support library, this could be more specific. The code lifecyclecurrentState.isAtLeast(Lifecycle.State.RESUMED) means, if current state is at least onResume, not later than it? Which makes sure my method won't be execute during some other life state(like onStop).


lifecyclecurrentState.isAtLeast(Lifecycle.State.RESUMED)


onResume


onStop



Is it all done?



Of course not. The code I have shown tells some new way to prevent application from crashing. But if it do go to the state of onStop, that line of code wont do things and thus show nothing on your screen. When users come back to the application, they will see an empty screen, that's the empty host activity showing no fragments at all. It's bad experience(yeah a little bit better than a crash).


onStop



So here I wish there could be something nicer: app won't crash if it comes to life state later than onResume, the transaction method is life state aware; besides, the activity will try continue to finished that fragment transaction action, after the user come back to our app.


onResume



I add something more to this method:


class FragmentDispatcher(_host: FragmentActivity) : LifecycleObserver
private val hostActivity: FragmentActivity? = _host
private val lifeCycle: Lifecycle? = _host.lifecycle
private val profilePendingList = mutableListOf<BaseFragment>()

@OnLifecycleEvent(Lifecycle.Event.ON_RESUME)
fun resume()
if (profilePendingList.isNotEmpty())
showFragment(profilePendingList.last())



fun dispatcherFragment(frag: BaseFragment)
if (lifeCycle?.currentState?.isAtLeast(Lifecycle.State.RESUMED) == true)
showFragment(frag)
else
profilePendingList.clear()
profilePendingList.add(frag)



private fun showFragment(frag: BaseFragment)
hostActivity?.let
Transaction.begin(it, R.id.frag_container)
.show(frag)
.commit()





I maintain a list inside this dispatcher class, to store those fragment don't have chance to finish the transaction action. And when user come back from home screen and found there is still fragment waiting to be launched, it will go to the resume() method under the @OnLifecycleEvent(Lifecycle.Event.ON_RESUME) annotation. Now I think it should be working like I expected.


dispatcher


resume()


@OnLifecycleEvent(Lifecycle.Event.ON_RESUME)





It would be nice to use Java instead of Kotlin
– Shchvova
Apr 27 at 18:00



Short And working Solution :



Follow Simple Steps



Steps



Step 1 : Override onSaveInstanceState state in respective fragment. And remove super method from it.


onSaveInstanceState


@Override
public void onSaveInstanceState( Bundle outState )




Step 2 : Use
fragmentTransaction.commitAllowingStateLoss( );


fragmentTransaction.commitAllowingStateLoss( );



instead of fragmentTransaction.commit( ); while fragment operations.


fragmentTransaction.commit( );





Answer is not copied or refereed form else where .Is was posted to help to people by my working solution which is got by several trial and error
– Vinayak
Oct 27 '17 at 14:25



BEWARE, using transaction.commitAllowingStateLoss() could result in a bad experience for the user. For more information on why this exception is thrown, see this post.


transaction.commitAllowingStateLoss()





This does not provide answer to the question, you must provide a valid answer for the question
– Umar Ata
Feb 13 at 12:32



I found a dirty solution for this kind of problem. If you still want to keep your ActivityGroups for whatever reason (I had time limitation reasons), you just implement


ActivityGroups


public void onBackPressed()



in your Activity and do some back code in there. even if there is no such Method on older Devices, this Method gets called by newer ones.


Activity


back



Do not use commitAllowingStateLoss(), it should only be used for cases where it is okay for the UI state to change unexpectedly on the user.



https://developer.android.com/reference/android/app/FragmentTransaction.html#commitAllowingStateLoss()



If the transaction happens in ChildFragmentManager of parentFragment, use
parentFragment.isResume() outside to check instead.


if (parentFragment.isResume())
DummyFragment dummyFragment = DummyFragment.newInstance();
transaction = childFragmentManager.BeginTransaction();
trans.Replace(Resource.Id.fragmentContainer, startFragment);



I had a similar problem, the scenario was like this:



The onCreate method of the activity was like this:


mMainFragment = (SelectionFragment) getSupportFragmentManager()
.findFragmentByTag(MAIN_FRAGMENT_TAG);
if (mMainFragment == null)
mMainFragment = new SelectionFragment();

mMainFragment.setListAdapter(new ArrayAdapter<String>(this,
R.layout.item_main_menu, getResources().getStringArray(
R.array.main_menu)));
mMainFragment.setOnSelectionChangedListener(this);
FragmentTransaction transaction = getSupportFragmentManager()
.beginTransaction();
transaction.add(R.id.content, mMainFragment, MAIN_FRAGMENT_TAG);
transaction.commit();



The exception was thrown because the when configuration changes (device rotated), the activity is created, the main fragment is retrieved from the history of the fragment manager and at the same time the fragment already has an OLD reference to the destroyed activity



changing the implementation to this solved the problem:


mMainFragment = (SelectionFragment) getSupportFragmentManager()
.findFragmentByTag(MAIN_FRAGMENT_TAG);
if (mMainFragment == null)
mMainFragment = new SelectionFragment();

mMainFragment.setListAdapter(new ArrayAdapter<String>(this,
R.layout.item_main_menu, getResources().getStringArray(
R.array.main_menu)));
FragmentTransaction transaction = getSupportFragmentManager()
.beginTransaction();
transaction.add(R.id.content, mMainFragment, MAIN_FRAGMENT_TAG);
transaction.commit();

mMainFragment.setOnSelectionChangedListener(this);



you need to set your listeners each time the activity is created to avoid the situation where the fragments have references to old destroyed instances of the activity.



I was getting this exception when i was pressing back button to cancel intent chooser on my map fragment activity.
I resolved this by replacing the code of onResume(where i was initializing the fragment) to onstart() and the app is working fine.Hope it helps.



I think using transaction.commitAllowingStateLoss(); is not best solution.
This exception will be thrown when activity's configuration changed and fragment onSavedInstanceState() is called and thereafter your async callback method tries to commit fragment.


transaction.commitAllowingStateLoss();


onSavedInstanceState()



Simple solution could be check whether activity is changing configuration or not



e.g. check isChangingConfigurations()


isChangingConfigurations()



i.e.



if(!isChangingConfigurations())
//commit transaction.


if(!isChangingConfigurations())
//commit transaction.



Checkout this link as well





Somehow I got this exception when the user clicks on something (the click is the trigger to do the transaction-commit ). How could this be? Would your solution here here?
– android developer
Sep 21 '15 at 11:24





@androiddeveloper what else are you doing on user click. somehow fragment is saving its state before you commit the transaction
– Amol Desai
Sep 23 '15 at 11:24





The exception was thrown on the exact line of transaction commit. Also, I had a weird typo: instead of "here here" I meant "work here" .
– android developer
Sep 23 '15 at 20:29





@androiddeveloper you are right! but before committing transaction are you spawning any background thread or something?
– Amol Desai
Sep 24 '15 at 7:11





I don't think so (sorry I'm out of the office), but why would it matter? It's all UI stuff here... If I ever make something on a background thread, I would have exceptions there, plus I don't put UI related stuff on background threads, as it's too risky.
– android developer
Sep 24 '15 at 14:13



If you are doing some FragmentTransaction in onActivityResult what you can do you can set some boolean value inside onActivityResult then in onResume you can do your FragmentTransaction on the basis of the boolean value. Please refer the code below.


@Override
protected void onResume()
super.onResume;
if(isSwitchFragment)
isSwitchFragment=false;
bottomNavigationView.getTabAt(POS_FEED).select();



@Override
protected void onActivityResult(int requestCode, int resultCode, Intent data)
if (requestCode == FilterActivity.FILTER_REQUEST_EVENT && data != null)
isSwitchFragment=true;






Please do not post code as an image, use code formatting instead.
– Micer
Apr 11 at 12:33





Yes it helped me.., This the exact and proper solution for marshmallow device i got this exception and solved with this simple trick..!! Hence up voted.
– sandhya sasane
Sep 16 at 15:24



Possibly the smoothest and the simplest solution I found in my case was to avoid popping the offending fragment off the stack in response to activity result. So changing this call in my onActivityResult():


onActivityResult()


popMyFragmentAndMoveOn();



to this:


new Handler(Looper.getMainLooper()).post(new Runnable()
public void run()
popMyFragmentAndMoveOn();




helped in my case.



Whenever you are trying to load a fragment in your activity make sure that activity is in resume and not going to pause state.In pause state you may end up losing commit operation that is done.



You can use transaction.commitAllowingStateLoss() instead of transaction.commit() to load fragment



or



Create a boolean and check if activity is not going to onpause


@Override
public void onResume()
super.onResume();
mIsResumed = true;


@Override
public void onPause()
mIsResumed = false;
super.onPause();



then while loading fragment check


if(mIsResumed)
//load the your fragment



In regards to @Anthonyeef great answer, here is a sample code in Java:


private boolean shouldShowFragmentInOnResume;

private void someMethodThatShowsTheFragment()

if (this.getLifecycle().getCurrentState().isAtLeast(Lifecycle.State.RESUMED))
showFragment();
else
shouldShowFragmentInOnResume = true;



private void showFragment()
//Your code here


@Override
protected void onResume()
super.onResume();

if (shouldShowFragmentInOnResume)
shouldShowFragmentInOnResume = false;
showFragment();




Add this in your activity


@Override
public void onSaveInstanceState(Bundle outState)
super.onSaveInstanceState(outState);
if (outState.isEmpty())
// Work-around for a pre-Android 4.2 bug
outState.putBoolean("bug:fix", true);




Starting from support library version 24.0.0 you can call FragmentTransaction.commitNow() method which commits this transaction synchronously instead of calling commit() followed by executePendingTransactions(). As documentation says this approach even better:


FragmentTransaction.commitNow()


commit()


executePendingTransactions()



Calling commitNow is preferable to calling commit() followed by executePendingTransactions() as the latter will have the side effect of attempting to commit all currently pending transactions whether that is the desired behavior or not.



I have also experienced this issue and problem occurs every time when context of your FragmentActivity gets changed (e.g. Screen orientation is changed, etc.). So the best fix for it is to update context from your FragmentActivity.


FragmentActivity


FragmentActivity



The exception is threw here (In FragmentActivity):


@Override
public void onBackPressed()
if (!mFragments.getSupportFragmentManager().popBackStackImmediate())
super.onBackPressed();




In FragmentManager.popBackStatckImmediate()FragmentManager.checkStateLoss() is called firstly. That's the cause of IllegalStateException. See the implementation below:


FragmentManager.popBackStatckImmediate()


FragmentManager.checkStateLoss()


IllegalStateException


private void checkStateLoss()
if (mStateSaved) // Boom!
throw new IllegalStateException(
"Can not perform this action after onSaveInstanceState");

if (mNoTransactionsBecause != null)
throw new IllegalStateException(
"Can not perform this action inside of " + mNoTransactionsBecause);




I solve this problem simply by using a flag to mark Activity's current status. Here's my solution:


public class MainActivity extends AppCompatActivity
/**
* A flag that marks whether current Activity has saved its instance state
*/
private boolean mHasSaveInstanceState;

@Override
protected void onCreate(Bundle savedInstanceState)
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_main);


@Override
protected void onSaveInstanceState(Bundle outState)
mHasSaveInstanceState = true;
super.onSaveInstanceState(outState);


@Override
protected void onResume()
super.onResume();
mHasSaveInstanceState = false;


@Override
public void onBackPressed()
if (!mHasSaveInstanceState)
// avoid FragmentManager.checkStateLoss()'s throwing IllegalStateException
super.onBackPressed();






I ended up with creating a base fragment and make all fragments in my app extend it


public class BaseFragment extends Fragment

private boolean mStateSaved;

@CallSuper
@Override
public void onSaveInstanceState(Bundle outState)
mStateSaved = true;
super.onSaveInstanceState(outState);


/**
* Version of @link #show(FragmentManager, String) that no-ops when an IllegalStateException
* would otherwise occur.
*/
public void showAllowingStateLoss(FragmentManager manager, String tag)
// API 26 added this convenient method
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O)
if (manager.isStateSaved())
return;



if (mStateSaved)
return;


show(manager, tag);




Then when I try to show a fragment I use showAllowingStateLoss instead of show


showAllowingStateLoss


show



like this:


MyFragment.newInstance()
.showAllowingStateLoss(getFragmentManager(), MY_FRAGMENT.TAG);



I came up to this solution from this PR: https://github.com/googlesamples/easypermissions/pull/170/files



Another possible workaround, which I'm not sure if helps in all cases (origin here) :


@Override
protected void onSaveInstanceState(Bundle outState)
super.onSaveInstanceState(outState);
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT)
final View rootView = findViewById(android.R.id.content);
if (rootView != null)
rootView.cancelPendingInputEvents();





I know there is an accepted answer by @Ovidiu Latcu but after some while, error still persist.


@Override
protected void onSaveInstanceState(Bundle outState)
//No call for super(). Bug on API Level > 11.



Crashlytics still sending me this weird error message.



However error now occurring only on version 7+ (Nougat)
My fix was to use commitAllowingStateLoss() instead of commit() at the fragmentTransaction.



This post is helpful for commitAllowingStateLoss() and never had a fragment issue ever again.



To sum it up, the accepted answer here might work on pre Nougat android versions.



This might save someone a few hours of searching.
happy codings. <3 cheers



I had the exact same problem.
It happened because of the destruction of previous activity.
when ı backed the previous activity it was destroyed.
I put it base activity (WRONG)


@Override
protected void onCreate(Bundle savedInstanceState)
super.onCreate(savedInstanceState);
SpinnerCustom2.setFragmentManager(getSupportFragmentManager());
onCreateDrawerActivity(savedInstanceState);



I put it into onStart it was RIGHT


@Override
protected void onStart()
super.onStart();
SpinnerCustom2.setFragmentManager(getSupportFragmentManager());




To bypass this issue, we can use The Navigation Architecture Component , which was introduced in Google I/O 2018.
The Navigation Architecture Component simplifies the implementation of navigation in an Android app.



Courtesy: Solution for IllegalStateException



This issue had annoyed me for a lot of time but fortunately I came with a concrete solution for it. A detailed explanation of it is here.



Using commitAllowStateloss() might prevent this exception but would lead to UI irregularities.So far we have understood that IllegalStateException is encountered when we try to commit a fragment after the Activity state is lost- so we should just delay the transaction until the state is restored.It can be simply done like this



Declare two private boolean variables


public class MainActivity extends AppCompatActivity {

//Boolean variable to mark if the transaction is safe
private boolean isTransactionSafe;

//Boolean variable to mark if there is any transaction pending
private boolean isTransactionPending;



Now in onPostResume() and onPause we set and unset our boolean variable isTransactionSafe. Idea is to mark trasnsaction safe only when the activity is in foreground so there is no chance of stateloss.


/*
onPostResume is called only when the activity's state is completely restored. In this we will
set our boolean variable to true. Indicating that transaction is safe now
*/
public void onPostResume()
super.onPostResume();
isTransactionSafe=true;

/*
onPause is called just before the activity moves to background and also before onSaveInstanceState. In this
we will mark the transaction as unsafe
*/

public void onPause()
super.onPause();
isTransactionSafe=false;



private void commitFragment()
if(isTransactionSafe)
MyFragment myFragment = new MyFragment();
FragmentManager fragmentManager = getFragmentManager();
FragmentTransaction fragmentTransaction = fragmentManager.beginTransaction();
fragmentTransaction.add(R.id.frame, myFragment);
fragmentTransaction.commit();




-What we have done so far will save from IllegalStateException but our transactions will be lost if they are done after the activity moves to background, kind of like commitAllowStateloss(). To help with that we have isTransactionPending boolean variable


public void onPostResume()
super.onPostResume();
isTransactionSafe=true;
/* Here after the activity is restored we check if there is any transaction pending from
the last restoration
*/
if (isTransactionPending)
commitFragment();




private void commitFragment()

if(isTransactionSafe)
MyFragment myFragment = new MyFragment();
FragmentManager fragmentManager = getFragmentManager();
FragmentTransaction fragmentTransaction = fragmentManager.beginTransaction();
fragmentTransaction.add(R.id.frame, myFragment);
fragmentTransaction.commit();
isTransactionPending=false;
else
/*
If any transaction is not done because the activity is in background. We set the
isTransactionPending variable to true so that we can pick this up when we come back to
foreground
*/
isTransactionPending=true;







By clicking "Post Your Answer", you acknowledge that you have read our updated terms of service, privacy policy and cookie policy, and that your continued use of the website is subject to these policies.

Popular posts from this blog

Firebase Auth - with Email and Password - Check user already registered

Dynamically update html content plain JS

How to determine optimal route across keyboard