Clash Royale CLAN TAG#URR8PPP

orderby in foreach loop loosing scope

having some trouble with something very easy (i hope)

i am receiving an array for sorting. I've created a dictionary for the keyselector.
But i am missing the last piece to fix then ThenBy instead or re-ordering them everytime.

ThenBy

public List<Vehicle> OrderBy(string sorting, List<Vehicle> vehicles)

return Order(sorting, vehicles, SortingFiltersVehicle);


//this is a generic implementation
private List<T> Order<T>(string sorting, List<T> vehicles, IDictionary<string, Func<T, object>> filters)

if (!sorting.HasAnyValue())
return vehicles;

foreach (var orderby in sorting)

var key = orderby.Split("-")[0];
if (filters.ContainsKey(key.Trim()))

var direction = orderby.Contains("desc") ? OrderByDirection.Descending : OrderByDirection.Ascending;
vehicles = vehicles.OrderBy(filters[key], direction).ToList(); <== here is the problem



return vehicles;


private static readonly IDictionary<string, Func<Vehicle, object>> SortingFiltersVehicle = new Dictionary<string, Func<Vehicle, object>>

"price", v => v.DiscountedPrice ,
"make", v => v.Make ,
"model", v => v.Model ,
"trimline", v => v.Trimline ,
;


OrderBy

OrderByDirection

filters

OrderBy

OrderByDirection

-

filters

SortingFiltersVehicle

1 Answer
1

Untested, but this looks like it should work:

private List<T> Order<T>(string sorting, List<T> vehicles,
IDictionary<string, Func<T, object>> filters)

if (!sorting.Any()) return vehicles;

IOrderedEnumerable<T> sorted = null;
foreach (var orderby in sorting)

var key = orderby.Split("-")[0];
if (filters.ContainsKey(key.Trim()))

var desc = orderby.Contains("desc");
var filter = filters[key];
if (sorted == null) sorted = desc ? vehicles.OrderByDescending(filter) : vehicles.OrderBy(filter);
else sorted = desc ? sorted.ThenByDescending(filter) : sorted.ThenBy(filter);



return sorted?.ToList() ?? vehicles;



if (sorted == null) sorted = desc ? vehicles.OrderByDescending(filter) : vehicles.OrderBy(filter);

By clicking "Post Your Answer", you acknowledge that you have read our updated terms of service, privacy policy and cookie policy, and that your continued use of the website is subject to these policies.